wasphin commented on PR #3612: URL: https://github.com/apache/brpc/pull/3612#issuecomment-6541789840
Could we drop the dedicated regression test here? This is a straightforward include-order adjustment, and checking the generated compiler flags alongside the existing build CI seems sufficient. The fake-header fixture adds maintenance overhead and can fail when the selected Protobuf headers live in a default system directory such as `/usr/include`, since ordinary `-I` paths are searched first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
