chenBright commented on code in PR #3692:
URL: https://github.com/apache/brpc/pull/3692#discussion_r4439071545
##########
src/brpc/policy/dynpart_load_balancer.cpp:
##########
@@ -114,7 +114,13 @@ int DynPartLoadBalancer::SelectServer(const SelectIn& in,
SelectOut* out) {
return EHOSTDOWN;
}
int64_t total_weight = 0;
- std::pair<SocketUniquePtr, int64_t> ptrs[8];
+ std::pair<SocketUniquePtr, int64_t> stack_ptrs[8];
+ std::vector<std::pair<SocketUniquePtr, int64_t> > heap_ptrs;
Review Comment:
The project already uses C++14, so no space is needed between the closing
brackets of nested templates. Please use
`std::vector<std::pair<SocketUniquePtr, int64_t>> heap_ptrs;`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
