songgaoye opened a new pull request, #3702:
URL: https://github.com/apache/brpc/pull/3702
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
`RedisClusterChannel` makes avoidable copies while parsing commands and
aggregating `MGET` replies:
- Parsed commands are copied into the command list after construction.
- Each sub-reply is shared into an intermediate vector and then shared again
into the final Redis reply, causing redundant `IOBuf` block-reference
operations.
### What is changed and the side effects?
Changed:
- Move completed `ParsedCommand` objects into the parsed command list.
- Move each `MGET` sub-reply into the intermediate reply vector.
- Move intermediate replies into the final aggregated reply.
Side effects:
- Performance effects:
Avoids copying command argument vectors and eliminates two `IOBuf`
block-reference copy/release cycles per aggregated `MGET` element.
- Breaking backward compatibility:
None.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
