wwbmmm commented on PR #3715: URL: https://github.com/apache/brpc/pull/3715#issuecomment-6704496539
What's the user case of this feature? The Problem Summary in the description is empty, and the tree already has per-tag polling implementations with dedicated poller bthreads for URMA (`urma_use_polling`) and UBShm. Please state which component is expected to use this generic facility. If the intent is to replace those implementations, the migration (or at least a concrete plan for it) should be part of this PR; otherwise we add a large public API with no in-tree user and no way to validate the contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
