wwbmmm commented on code in PR #3645:
URL: https://github.com/apache/brpc/pull/3645#discussion_r4500923232
##########
src/brpc/options.proto:
##########
@@ -37,7 +37,7 @@ enum ConnectionType {
enum ProtocolType {
PROTOCOL_UNKNOWN = 0;
- PROTOCOL_RDMA_HANDSHAKE = 1;
+ PROTOCOL_TRANSPORT_HANDSHAKE = 1;
Review Comment:
[replied by brpc-oncall robot] Renaming `PROTOCOL_RDMA_HANDSHAKE` to
`PROTOCOL_TRANSPORT_HANDSHAKE` (and the registered name in global.cpp from
"rdma_handshake" to "transport_handshake") is not an internal rename; both are
user-visible identifiers. `ServerOptions.enabled_protocols` is matched by the
exact registered string and `BuildAcceptor()` returns nullptr for any leftover
unknown name, so `Server::Start()` fails with "Fail to build acceptor" for
every deployment that currently lists `rdma_handshake` (a name server.h
previously documented as valid). User code that references
`PROTOCOL_RDMA_HANDSHAKE` also stops compiling. Since no wire format or
behavior changes here, please keep the existing enum name and registered name,
or at least accept the old name as an alias (erase "rdma_handshake" from the
whitelist and map it to the new protocol) so existing configurations keep
working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
