chenBright commented on PR #3709: URL: https://github.com/apache/brpc/pull/3709#issuecomment-6630055147
All three review comments are declined. The ABI changes are intentional: users rebuild brpc and its consumers with matching headers when upgrading. The Babylon finding is a false positive because the affected tests are already guarded by `#if !WITH_BABYLON_COUNTER`. No further changes are required for these comments. This PR is ready for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
