randomkang commented on code in PR #3144:
URL: https://github.com/apache/brpc/pull/3144#discussion_r4513300027
##########
src/brpc/channel.cpp:
##########
@@ -145,6 +145,8 @@ static ChannelSignature ComputeChannelSignature(const
ChannelOptions& opt) {
buf.append("|rdma");
} else if (opt.socket_mode == SOCKET_MODE_URMA) {
buf.append("|urma");
+ } else if (opt.socket_mode == SOCKET_MODE_GDR) {
+ buf.append("|gdr");
Review Comment:
OK,We limit that only SOCKET_MODE_TCP can return ComputeChannelSignature().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]