songgaoye opened a new pull request, #3725: URL: https://github.com/apache/brpc/pull/3725
### What problem does this PR solve? Issue Number: resolve Problem Summary: Reusing a `DoublyBufferedData::ScopedPtr` in consecutive `Read()` calls does not end the previous read guard. In the default mode, the second read may deadlock while trying to lock the same mutex again. When bthread suspension is allowed, it can leave a reader reference outstanding and cause a later `Modify()` to wait indefinitely. ### What is changed and the side effects? Changed: - Add `ScopedPtr::reset()` to end an active read and clear the guard state. - Reset the previous guard before reusing a `ScopedPtr` in `Read()`. - Add a regression test covering both read modes. Side effects: - Performance effects: Reusing a `ScopedPtr` now releases its previous read guard before acquiring a new one. - Breaking backward compatibility: No intended API break. A successful `Read()` into an existing `ScopedPtr` now ends its previous read. --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
