chenBright commented on code in PR #3720:
URL: https://github.com/apache/brpc/pull/3720#discussion_r4546528997
##########
src/brpc/rdma/rdma_helper.cpp:
##########
@@ -135,6 +138,14 @@ static void GlobalRelease() {
RdmaEndpoint::GlobalRelease();
+ SrqReceivePool::RetryDeregistrations();
+ if (SrqWorkerCount() != 0 || SrqReceivePool::RegisteredBytes() != 0) {
Review Comment:
The reported race is prevented by the existing ownership model.
`Create()` synchronously registers a nonempty initial region before
background growth can start. Each growth task holds a pool reference, and
stopping the worker only releases the worker's reference. The initial region
remains registered until the last pool reference is released.
Therefore, `RegisteredBytes()` cannot become zero while an outstanding
growth task can still register memory using the PD/context. The existing
retention condition covers this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]