randomkang commented on code in PR #3144:
URL: https://github.com/apache/brpc/pull/3144#discussion_r4547049083
##########
src/brpc/rdma/rdma_handshake_server.cpp:
##########
@@ -207,8 +207,14 @@ ParseResult ExecuteServerHandshake(butil::IOBuf* source,
Socket* socket) {
// Only RDMA-mode connections carry a live RdmaEndpoint and run the real
// handshake. A connection that is not in RDMA mode (RDMA compiled in but
// this connection is plain TCP, or RDMA not compiled at all) falls back.
+ // GDR is a special mode of RDMA: it shares the same RDMA handshake.
#if BRPC_WITH_RDMA
- if (socket->socket_mode() == SOCKET_MODE_RDMA) {
+ SocketMode mode = socket->socket_mode();
+ if (mode == SOCKET_MODE_RDMA
+#if BRPC_WITH_GDR
+ || mode == SOCKET_MODE_GDR
Review Comment:
yes, we should reject gdr when start server with protocol which is not
baidu_std.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]