darion-yaphet opened a new pull request, #3742:
URL: https://github.com/apache/brpc/pull/3742

   ### What problem does this PR solve?
   
   Problem Summary:
   
   `Acceptor::Join()` can return after a connection is removed from the 
Acceptor's
   map while its event task still holds a KeyTable. Waiting for connections 
alone
   therefore does not establish that the related tasks have crossed the TLS exit
   boundary.
   
   ### What is changed and the side effects?
   
   Changed:
   
   - Add a lifecycle context for admission, draining, and retirement of tasks
     associated with explicitly registered TLS pools.
   - Acquire task leases before TaskGroup publishes work and release them after
     KeyTable cleanup and task completion notification.
   - Allow admitted same-generation tasks to derive child tasks while draining,
     and reject new independent tasks after admission closes.
   - Add tests for connection and task exit boundaries, TLS destructor ordering,
     task admission, and draining races.
   
   This PR provides task-tracking infrastructure. Server and Socket 
registration,
   direct TLS access checks, and the complete strict Stop/Join protocol remain 
to
   be integrated.
   
   Side effects:
   - Performance effects: Task creation with a non-null pool performs a 
lifecycle
     hook check. Registered pools also require registry lookup and lease
     management. Performance has not yet been measured.
   
   - Breaking backward compatibility: Public pool and attribute layouts are
     unchanged. The internal TaskMeta and LocalStorage layouts change; full
     library ABI compatibility has not been established.
   
   ### Testing
   
   - Production `brpc-static` build passed.
   - Six CTest programs passed: context, task integration, lifecycle hook, 
Socket,
     Key, and bthread.
   - The context and task integration suites passed 20 shuffled repetitions in
     both normal and ASan builds.
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to