darion-yaphet commented on code in PR #3682:
URL: https://github.com/apache/brpc/pull/3682#discussion_r4566317662
##########
src/bthread/key.cpp:
##########
@@ -257,6 +257,24 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTableList {
_length++;
}
+ // Transfer the entire chain without invoking KeyTable destructors. The
+ // caller uses this while holding the cache-management locks, then destroys
+ // the receiving list after releasing those locks.
+ void append_list(KeyTableList* other) {
Review Comment:
> `append_list` -> `transfer_list_from`?
Good Point ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
