PDGGK commented on PR #3741: URL: https://github.com/apache/brpc/pull/3741#issuecomment-6867780452
On the Copilot notes: the file already includes C headers (`<stdlib.h>`, `<netdb.h>`), so `<string.h>` follows it; brpc uses both forms. The lowercase `ipv6` matches existing log text such as `for ipv6, fallback to ipv4`. `GetServers` clears `servers` before filling it (line 39), and the new test relies on that the same way the other naming service tests reuse their vector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
