chenBright opened a new pull request, #3745: URL: https://github.com/apache/brpc/pull/3745
### What problem does this PR solve? Issue Number: resolve Problem Summary: A client using RDMA handshake v3 fails when a legacy server only supports v2. Clients should automatically select a compatible protocol without consuming RPC retries. Handshake failures must also preserve connection timeout error conversion and allow pending reconnects to stop when the socket fails. ### What is changed and the side effects? Changed: - Start every new connection with v3. Reconnect and retry v2 once if the peer closes or resets the connection before returning v3 magic, or returns v2 magic. - Preserve the original connection deadline and queued request without consuming `max_retry`. - Let the connection completion callback record the final error, preserving `ETIMEDOUT` to `ENETUNREACH` conversion. - Make reconnect waits respond to socket failure without missing cancellation notifications. Preserve health checks on failed sockets. - Retain `rdma_client_handshake_version` as a deprecated, ignored flag so existing startup arguments remain accepted. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
