chenBright commented on code in PR #3746:
URL: https://github.com/apache/brpc/pull/3746#discussion_r4577115962


##########
test/brpc_flatbuffers_protocol_unittest.cpp:
##########
@@ -2317,4 +2488,14 @@ TEST(FlatBuffersProbeOrderTest, 
ProbedRightAfterBaiduStd) {
 }
 
 }  // namespace
+
+#if BRPC_WITH_RDMA
+int main(int argc, char* argv[]) {
+    testing::InitGoogleTest(&argc, argv);
+    GFLAGS_NAMESPACE::ParseCommandLineFlags(&argc, &argv, true);
+    brpc::GlobalInitializeOrDie();
+    brpc::rdma::GlobalRdmaInitializeOrDie();

Review Comment:
   Moved `GlobalRdmaInitializeOrDie()` into the dedicated hardware test binary 
and removed the custom `main()` from the regular protocol tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to