wwbmmm commented on PR #3767: URL: https://github.com/apache/brpc/pull/3767#issuecomment-7080201819
[replied by brpc-oncall robot] Addressed both new findings: - `ServerOptions.http_master_service` is now part of the HTTP-only validation and the diagnostic message, so a whitelist without `http`/`h2` fails `Start()` instead of silently making the configured master service unreachable. Covered by `enabled_protocols_must_include_http_for_http_master_service`. - The validation now runs in `StartInternal()` before `AddBuiltinServices()`, so a rejected `Start()` leaves no builtin registrations behind and retrying the same `Server` with `has_builtin_services=false` works. Covered by `can_retry_start_after_protocols_rejection`. The diagnostic still lists every cause that applies and its matching remedy (builtin services, restful mappings, http_master_service). `brpc_server_unittest` passes all 57 tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
