A few things to consider:
1. I think we need to define which versions of IDEA these patches should work with. The last idea7x patch which I wrote was specifically for IDEA 7x. It seems each subsequent version of IDEA (8x and 9x) has had changes to the way they handle project and module files. 2. Version 8x of IDEA introduced a new way of defining project and module files. It's called the "directory-based" approach. I believe the new approach was to make it easier to share project files among team members by checking into a source repository. The older project files apparently were hard to keep in sync because of merge conflicts, etc. Do these patches address the traditional project files or the new directory-based approach? 3. Having gone through the process of trying to keep changes in Buildr and IDEA project files in synch along with changing formats with each new IDEA version, I finally gave up. I propose a more clearly defined approach which addresses differences between IDEA project file version formats. Perhaps a departure from idea vs idea7x tasks and have one idea task with a param indicating which version to generate the project files for? That all being said, I'm willing to help in this effort. -Shane On Wed, Feb 24, 2010 at 1:13 AM, Alex Boisvert <[email protected]>wrote: > On Tue, Feb 23, 2010 at 9:18 PM, Alex Boisvert <[email protected] > >wrote: > > > Any committer wants to step in and review these patches? > > https://issues.apache.org/jira/browse/BUILDR-376 > > https://issues.apache.org/jira/browse/BUILDR-377 > > > > I don't use IDEA and I'm not familiar with their project descriptions. > > > > While we're at it there's also this one to be reviewed, > https://issues.apache.org/jira/browse/BUILDR-369 > > In lieu of specs (which are sadly missing for IDEA), I could be consoled if > fellow IDEA contributors cross-reviewed their patches. i.e., Alexis > reviewing BUILDR-376/377 and Peter reviewing BUILDR-369, or anybody else... > > Just indicate so on the issue itself to help expedite the process. > > thanks! > alex >
