Will do - I did not apply the previous one to SVN btw, just locally. Thanks for your hard work!
On Wed, Jun 2, 2010 at 05:42, Pepijn Van Eeckhoudt < [email protected]> wrote: > After some further investigation I've backtracked on my first fix attempt. > I had assumed that utime to a time in the past was not working but in > actuality it was utime on directories that was simply not working at all. I > patched JRuby to fix this and have restarted my testing effort from scratch. > > I first wrote some specs to check that utime works on files, directories, > in the past and in the future. Once those were working I reran all the specs > and hooray most of them worked immediately. > > I've fixed a number of misc other things to get the remaining failing ones > to work: > - Disabled ZipTask:'should preserve file permissions' on windows as this > cannot be implemented correctly yet. > - Added URI.escape() around all file:// URLs in the specs to make sure > directories with spaces are handled correctly > - Patched FILE#real_path to return an unescaped version of the path so that > we don't get %20 directories on the local FS > - Allowed mode flags to be passed to Buildr#read. Due to CRLF to LF > conversion the signature validation spec was failing. This spec now uses > 'rb' as mode flags > > I'll attach all this stuff as a new patch to BUILDR-499. Antoine, could you > revert the previous patch and apply the new one and then retest please? > > Regards, > > Pepijn > > > On 1/6/2010 17:20, Pepijn Van Eeckhoudt wrote: > >> JRUBY-4837 >> >> Op 1-jun-2010 om 17:13 heeft Antoine Toulme <[email protected]> >> het volgende geschreven:\ >> >> I'll give it a try today. We might be lucky and have your patch >>> accepted for >>> 1.5.1 - I'll chat with the JRuby team about it. >>> Do you have the bug number ? >>> >>> On Tue, Jun 1, 2010 at 07:45, Pepijn Van Eeckhoudt >>> <[email protected]>wrote: >>> >>> I've traced the directory utime issue back to the jnr-posix project >>>> which >>>> is used by JRuby. I've patched the bug and submitted the patch back >>>> to the >>>> JRuby guys. This means we'll have to wait for a new JRuby build >>>> before this >>>> can be resolved from a buildr point of view. Should this block the >>>> buildr >>>> 1.4 release or not? >>>> >>>> I've also created a bug in the buildr jira project with the spec patches >>>> attached. Could someone else give these a try? >>>> >>>> Pepijn >>>> >>>> > > -- > Pepijn Van Eeckhoudt - Project Leader > T +32 16 23 95 91 > F +32 16 29 34 22 | [email protected] > > LUCIAD - high performance visualization > Wetenschapspark Arenberg | Gaston Geenslaan 11 > 3001 Leuven | Belgium | www.luciad.com > >
