Alrighty, patch applied. I didn't really have an opinion on the syntax so left it as-is.
Thanks for taking the time to write a spec and update the documentation. If all patches were this easy... alex On Wed, Dec 1, 2010 at 11:11 AM, Alex Boisvert <[email protected]>wrote: > Hi Mikael, > > Thanks for the gentle reminder. I think it was simply overlooked. I'll > look at it later today. > > alex > > > On Tue, Nov 30, 2010 at 10:36 PM, Mikael Amborn > <[email protected]>wrote: > >> Hi, >> >> I submitted a patch for jira issue BUILDR-125 (support for j2ee >> security tag in application.xml) a while ago and was wondering if >> anybody had had a chance to look at it yet? If so do you have any >> comments on the suggested syntax for adding security roles or about >> the code in the patch? >> >> Example buildfile syntax: >> >> package(:ear).security_roles << {:id=>'SecurityRole_123', >> :description=>'Read only user', :name=>'coolUser'} >> >> which would result in the following rows in the application.xml file: >> >> <security-role id="SecurityRole_123"> >> <description>Read only user</description> >> <role-name>coolUser</role-name> >> </security-role> >> >> Cheers, >> Mikael Amborn >> > >
