Hi,
On Wed, Jul 24, 2013 at 9:48 PM, Marius Kjeldahl
<[email protected]> wrote:
> I've now successfully added support for Kawa compilation using buildr.
great work.
> I've modelled the code on the existing Scala compilation support, basically
> added a kawa.rb and kawa/compiler.rb, with minor modifications to
> core/{compile,generate,run}.rb . Together with a proper buildfile I am now
> able to compile, package, install and run mixed language programs
> (java+scheme) on Android, although there is no Android specific code in the
> buildr contributions (only in the local buildfile), so it should support
> "generic Kawa" (non-Android) programs as well. I have not yet added support
> for unit testing or doc generation with kawa, but that should be fairly
> easy if needed.
excellent.
> I wouldn't mind contributing this code, but I am somewhat at a loss on how
> to do this. Ideally, I would have forked the public Github repo, but that
> looks stale, so it's obviously not that easy. Considering my kawa support
> is only a few days old, the kawa support should also be considered "alpha"
> quality, and there will probably be frequent fixes in the near future.
It would be awesome to have this contributed and forking the github
repo is an easy way to get it going. A few things to note;
* It looks like the github repo has an incorrect branch marked as the
primary branch. It should be trunk at
https://github.com/apache/buildr/tree/trunk - I will look into seeing
what is needed to get the github repository corrected so it shows the
trunk branch by default.
* the best way to get into core is to add tests for it. The more tests
that are added the more likely it will continue to be supported as
buildr evolves.
* Unfortunately Apache does not support pull requests as a mechanism
for integrating code into buildr. Once you have prepared a branch you
have to attach a patch to a jira issue and tick a box that assigns
copyright to the foundation. However working in a branch in your own
fork is actually fairly useful.
* It is up to you whether you want to incrementally or send a patch
when the support is complete. I would recommend incremental patches as
it is much easier to get feedback in small patches and it may be
easier to make it more consistent with the rest of buildr that way.
> Anyway, I'm not sure if or how I should contribute, or if I should just
> make a Github repo for myself and others (I'm sure there aren't that many
> yet..) containing the modifications.
I am jumping on a plane and heading out bush in a few hours but
hopefully will be back in range next week. I would love to have a look
at it then :)
--
Cheers,
Peter Donald
