Hey, A little correction, `zip` can actually not store any 'dev' nodes.
Seems like only ostree, tar and docker from what we have need this currently. Ben ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Wednesday, July 8, 2020 8:08 PM, Benjamin Schubert <[email protected]> wrote: > Hey, > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Monday, 6 July 2020 21:50, Chandan Singh [email protected] wrote: > > > I should also add that I'm +1 on Ben's medium-term proposal. > > Regarding where to implement it, I wonder if the > > DownloadableFileSource would be a better place than the tar source > > specifically. There is no particular reason a stage3 archive has to be > > a tar archive. Although tar is pretty common, there's nothing wrong > > with it being a zip, or any other archive format really. OSTree will > > still need to be handled differently than tar and friends, but that'd > > be the case either way. > > I tend to agree, but the way each of these plugins are done is quite > different, > and there would not be an easy way of filtering them like this. > > For example, the `tar` plugin, gives a handy `tarfile.isdev()` method that > allows us to check, but the API would be different for each plugin. > > I therefore think it would be simpler to implement it in a per-plugin basis. > > > Thanks, > > Chandan > > Cheers, > Ben
