Hi Tristan, On Tue, 2020-07-28 at 12:36 +0900, Tristan Van Berkom wrote: > On Tue, 2020-07-28 at 02:11 +0900, Tristan Van Berkom wrote: > > This is an interesting choice I'm not sure I have an answer to today, > > should we only allow parsing custom YAML on build dependencies, and > > call it an error to specify `config` on a dependency that is strictly a > > `runtime` dependency ? > > After sleeping on this I feel more strongly in favor of allowing this > on all dependencies regardless of `type`. > > The worst case scenario is that it happens to not be used with runtime- > only dependencies much.
The cache key does not change when there is a change in direct runtime dependencies. Only build and indirect runtime dependencies affect the cache key. Unless we want to change that, we should clearly not pass on any information about direct runtime dependencies to that new method, as direct runtime dependencies are not allowed to affect the build of that element. I.e., I think the worst case scenario is that this _is_ used with runtime-only dependencies and it affects builds without affecting the cache key. Or am I missing something? Cheers, Jürg
