Thank you Santi. I am looking forward to this change, thanks for taking it on.
If the glog patches are not accepted upstream, would we be OK to apply the patches in buildbox with, say, CMake at build time? This would provide nice features like custom prefixes and filenames, AIUI. Ed On Wed, 12 Aug 2020 at 13:26, Santiago Gil <[email protected]> wrote: > > Hi. > > We are planning on replacing the current logging mechanism provided by > buildbox-common with one that is thread-safe. > > The plan we had in mind involves switching to using google-glog [0]. > > In terms of required changes to the code base by users of the > buildbox-common > library, those would be minimal (no need to change any logging call > sites). > > However, glog has certain characteristics that would affect the > consumers of > the logs. In particular the changing of the format of the prefix that is > appended to log messages, as well as the filenames of logs when they are > written to disk. > > We are keeping track of this plan in a GitLab issue, which also contains > more > details about the changes this would bring. [1] > > We are open to any comments, suggestions or complaints about this > proposed > change, either as a reply to this message or on GitLab. > > Best, > Santiago > > > [0]: https://github.com/google/glog > [1]: https://gitlab.com/BuildGrid/buildbox/buildbox-common/-/issues/75 > > _______________________________________________ > Buildgrid mailing list > [email protected] > https://lists.buildgrid.build/cgi-bin/mailman/listinfo/buildgrid
