On 2021-01-10 09:28, Tristan Van Berkom wrote:
Hi all,
Hi Tristan,
Thanks for the updates
<snip>
* Status checks for CI which is running on pull requests don't seem
to appear in the pull request UI.
This may be only an issue for pull requests submitted from "forked"
repositories.
Since we expect most contributions to come from "forked" repos on
github, it would be good to fix this (and from prior experience,
I've
seen this work properly before on other projects).
E.g.: At the bottom of the page here:
https://github.com/apache/buildstream/pull/1436
We can see some status about the PR, but it is missing the status
from "workflow actions".
This was fixed by running CI on our repo on the `pull_request` event,
which will be triggered in our repo whenever a pull request is created
even if it is created from a downstream fork.
It is a well known issue that running CI on both "push" events and
"pull_request" events causes CI to run twice, which is wasteful,
however we do want the ability to run CI in advance of creating a pull
request.
While github has yet to provide a solution for this issue, I was able
to find this workaround[3], testing so far shows this is working as
expected.
This doesn't seem to work on this PR (generated from a fork, rebased
against current master): [1]
Cheers,
Javier
[1] https://github.com/apache/buildstream/pull/1436
