I'd prefer not to delete configuration properties just because we're not going to read them again. I am thinking of a situation where someone debugging is going to dump the config and they see the altered version and become confused.
Matt On Tue, Jul 2, 2013 at 1:22 AM, <[email protected]> wrote: > Author: rmannibucau > Date: Tue Jul 2 06:22:57 2013 > New Revision: 1498797 > > URL: http://svn.apache.org/r1498797 > Log: > no need to keep our internal property for executable validation types once > read > > Modified: > > bval/branches/bval-11/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheValidatorFactory.java > > Modified: > bval/branches/bval-11/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheValidatorFactory.java > URL: > http://svn.apache.org/viewvc/bval/branches/bval-11/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheValidatorFactory.java?rev=1498797&r1=1498796&r2=1498797&view=diff > > ============================================================================== > --- > bval/branches/bval-11/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheValidatorFactory.java > (original) > +++ > bval/branches/bval-11/bval-jsr303/src/main/java/org/apache/bval/jsr303/ApacheValidatorFactory.java > Tue Jul 2 06:22:57 2013 > @@ -130,7 +130,7 @@ public class ApacheValidatorFactory impl > executableTypes.addAll(impl.getExecutableValidation()); > toClose.add(impl.getClosable()); > } else { > - final String executableTypesStr = > getProperties().get(ApacheValidatorConfiguration.Properties.EXECUTABLE_VALIDATION_TYPES); > + final String executableTypesStr = > getProperties().remove(ApacheValidatorConfiguration.Properties.EXECUTABLE_VALIDATION_TYPES); > if (executableTypesStr != null && > !executableTypesStr.isEmpty()) { > for (final String s : executableTypesStr.split(",")) { > executableTypes.add(ExecutableType.valueOf(s.trim())); > > >
