Awesome. To critique my own PR, I probably need a test case in there :) I was kind of in a rush and cut a corner I shouldn't have.
Regardless, general thoughts are great. -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com > On May 21, 2019, at 1:00 PM, Thomas Andraschko <[email protected]> > wrote: > > Hi david, > > I will review it tommorow :) > > David Blevins <[email protected]> schrieb am Di., 21. Mai 2019, 21:43: > >> Hi All! >> >> I'm personally open to any of the proposed resolutions of BVAL-175. More >> important for me would be BVAL-174 as it blocks this feature: >> >> - http://tomee.apache.org/tomee-8.0/examples/mp-jwt-bean-validation.html >> <http://tomee.apache.org/tomee-8.0/examples/mp-jwt-bean-validation.html> >> >> Any chance this PR could be reviewed? >> >> - https://github.com/apache/bval/pull/3 < >> https://github.com/apache/bval/pull/3> >> >> >> -- >> David Blevins >> http://twitter.com/dblevins >> http://www.tomitribe.com >> >>
