If we want the relocation to work it is just a matter of fixing the shade configuration with a relocating transformer. Think it is the way to go since we have a fix since last release which is to support v3 descriptors so can be worth releasing like that then switching codebase to something closer to jakarta maybe since we don't upgrade it often.
Hope it makes sense. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le sam. 2 avr. 2022 à 10:57, Jean-Louis Monteiro <jlmonte...@tomitribe.com> a écrit : > In case it helps, here is what I had to do in order to get BVal to work in > TomEE in the jakarta namespace > > https://github.com/apache/tomee/tree/master/deps/bval-jsr-shade > > Apologies, this is dirty. > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Sat, Apr 2, 2022 at 10:53 AM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > If they are just for the relocation which still does not work because > > properties are not transformed. Then I agree there is no point in > releasing > > something that does not work and we'll do better by updating the source > > code itself > > > > Le ven. 1 avr. 2022 à 14:05, Thomas Andraschko < > > andraschko.tho...@gmail.com> a écrit : > > > >> the last commits, since the last latest release are just for shading > >> i can do the release but since we get a "real" jakarta version soon, not > >> sure if its required > >> > >> Am Fr., 1. Apr. 2022 um 13:21 Uhr schrieb Matt Benson < > mben...@apache.org > >> >: > >> > >> > I guess I haven't been in the right places to see what the > requirements > >> > have been for jakarta migration. Are the few recent commits to master > of > >> > such a nature that it would help users transition to have a last 2.0.x > >> > release? > >> > > >> > Matt > >> > > >> > On Fri, Apr 1, 2022, 4:20 AM Jean-Louis Monteiro < > >> jlmonte...@tomitribe.com > >> > > > >> > wrote: > >> > > >> > > Fine with one last release and then move to Jakarta. > >> > > > >> > > > >> > > Le ven. 1 avr. 2022 à 10:43, Romain Manni-Bucau < > >> rmannibu...@gmail.com> > >> > a > >> > > écrit : > >> > > > >> > > > We have other downstream consumers so guess javax fixes are needed > >> so > >> > ok > >> > > if > >> > > > there is no other fixes than jakarta relocation on master else we > >> > should > >> > > do > >> > > > at least one last javax release IMHO > >> > > > > >> > > > Romain Manni-Bucau > >> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> > > > <https://rmannibucau.metawerx.net/> | Old Blog > >> > > > <http://rmannibucau.wordpress.com> | Github < > >> > > > https://github.com/rmannibucau> | > >> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >> > > > < > >> > > > > >> > > > >> > > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >> > > > > > >> > > > > >> > > > > >> > > > Le ven. 1 avr. 2022 à 10:22, Thomas Andraschko < > >> > > > andraschko.tho...@gmail.com> > >> > > > a écrit : > >> > > > > >> > > > > As TomEE had some issues with the TKC and our shaded version - > >> what > >> > > about > >> > > > > doing a Big-Bang change in BVal now? > >> > > > > Sooner or later we have to do it anyway. BVal is probably the > >> most > >> > > > stable > >> > > > > lib around TomEE, so i would not care too much about > >> maintainability. > >> > > If > >> > > > we > >> > > > > have like 1 bug in 1/2 year, we can simply port it to a 2.0.x > >> branch. > >> > > > > > >> > > > > I would do the work, i just need a "go" ;D > >> > > > > > >> > > > > > >> > > > > Am Do., 24. März 2022 um 01:46 Uhr schrieb Matt Benson < > >> > > > mben...@apache.org > >> > > > > >: > >> > > > > > >> > > > > > New release sounds fine to me. I will try to better understand > >> this > >> > > new > >> > > > > > issue. > >> > > > > > > >> > > > > > Matt > >> > > > > > > >> > > > > > On Wed, Mar 23, 2022, 4:58 PM Romain Manni-Bucau < > >> > > > rmannibu...@gmail.com> > >> > > > > > wrote: > >> > > > > > > >> > > > > > > https://github.com/yupiik/maven-shade-transformers/ > >> > > > > > > > >> > > > > > > Romain Manni-Bucau > >> > > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> > > > > > > <https://rmannibucau.metawerx.net/> | Old Blog > >> > > > > > > <http://rmannibucau.wordpress.com> | Github < > >> > > > > > > https://github.com/rmannibucau> | > >> > > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >> > > > > > > < > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > Le mer. 23 mars 2022 à 22:44, Jean-Louis Monteiro < > >> > > > > > > jlmonte...@tomitribe.com> > >> > > > > > > a écrit : > >> > > > > > > > >> > > > > > > > Created also this one > >> > > > https://issues.apache.org/jira/browse/BVAL-215 > >> > > > > > > > It requires some thoughts for the fix > >> > > > > > > > -- > >> > > > > > > > Jean-Louis Monteiro > >> > > > > > > > http://twitter.com/jlouismonteiro > >> > > > > > > > http://www.tomitribe.com > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > On Wed, Mar 23, 2022 at 10:16 PM Romain Manni-Bucau < > >> > > > > > > rmannibu...@gmail.com > >> > > > > > > > > > >> > > > > > > > wrote: > >> > > > > > > > > >> > > > > > > > > sounds good > >> > > > > > > > > > >> > > > > > > > > Romain Manni-Bucau > >> > > > > > > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > >> > > > > > > > > <https://rmannibucau.metawerx.net/> | Old Blog > >> > > > > > > > > <http://rmannibucau.wordpress.com> | Github < > >> > > > > > > > > https://github.com/rmannibucau> | > >> > > > > > > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | > Book > >> > > > > > > > > < > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > Le mer. 23 mars 2022 à 21:57, Jean-Louis Monteiro < > >> > > > > > > > > jlmonte...@tomitribe.com> > >> > > > > > > > > a écrit : > >> > > > > > > > > > >> > > > > > > > > > Hi, > >> > > > > > > > > > > >> > > > > > > > > > I was working on TomEE for jakarta namespace and I > just > >> > > fixed a > >> > > > > > > > > relocation > >> > > > > > > > > > issue with BVal. I am currently deploying snapshots > and > >> > I'll > >> > > > use > >> > > > > > them > >> > > > > > > > in > >> > > > > > > > > > TomEE. But I wanted to know if there is any issue to > >> > release > >> > > > > 2.0.6 > >> > > > > > > and > >> > > > > > > > if > >> > > > > > > > > > not, is there anything pending you guys want to get > in? > >> > > > > > > > > > > >> > > > > > > > > > Overall, the only issue is the one I created to fix > >> > > relocation. > >> > > > > > > > > > -- > >> > > > > > > > > > Jean-Louis Monteiro > >> > > > > > > > > > http://twitter.com/jlouismonteiro > >> > > > > > > > > > http://www.tomitribe.com > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > >
