rmannibucau commented on PR #268: URL: https://github.com/apache/bval/pull/268#issuecomment-5876463924
Most look ok and in valid assumption zone but wonder why the pattern validator doesnt apply the same trick for all regexes (if some specific char are in the regex it can be tested with indexof before using the compiled pattern). Also I think it can be worth running the bench with only one change at a time to ensure they are all needed (if one gives you 100% of boost but you put a cache in front in next round and get another 100% of boost it means second one gave you 200% of boost and first one is useless for ex). Agree on the `ELFacade` point, not sure the replace is good. side note/open point: i know llm love package scope code cause it is trivial to test but we tend to avoid it so maybe worth adjusting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
