Can one or two Eclipse users please review the instructions that Alexander has put into https://issues.apache.org/jira/browse/CALCITE-994? You don’t need to be a committer. (I don’t use Eclipse so I’m no use.)
Hopefully we can agree on a section to http://calcite.apache.org/docs/howto.html. Julian > On Nov 23, 2015, at 12:31 PM, Alexander Reshetov > <alexander.v.reshe...@gmail.com> wrote: > > I see. Thanks for clarifications, Josh. > > On Mon, Nov 23, 2015 at 11:09 PM, Josh Elser <josh.el...@gmail.com> wrote: >> A summary (or copy-paste) of the relevant information you provided in the >> first two messages is, IMO, sufficient for the problem statement. >> >> A patch which creates that lifecycle-mapping-metadata.xml file and updates >> to the website (the Jekyll "project" in site/) would be awesome, but is not >> absolutely necessary. >> >> >> Alexander Reshetov wrote: >>> >>> Yes, sure. >>> >>> Should it contain screenshots or just text description? >>> >>> On Mon, Nov 23, 2015 at 7:00 PM, Josh Elser<josh.el...@gmail.com> wrote: >>>> >>>> Hi Alexander, >>>> >>>> Looks reasonable to me. I'll try to find some time to test this out >>>> myself >>>> -- I have been ignoring lots of eclipse-marked errors in the project to >>>> date >>>> :) >>>> >>>> Want to create an issue which contains the necessary >>>> lifecycle-mapping-metadata.xml file and some instructions for the >>>> website? >>>> >>>> - Josh >>>> >>>> >>>> Alexander Reshetov wrote: >>>>> >>>>> Checked out probably better solution. At least from project point of >>>>> view. >>>>> >>>>> While such behaviour Eclipse-specific, it may be better to manage >>>>> lifecycle mapping >>>>> directly in Eclipse without blowing up project's POMs. >>>>> >>>>> This feature is available from Eclipse 4.2 as described in >>>>> https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html >>>>> part "Eclipse 4.2 Adds Default Mapping". >>>>> >>>>> Note: while this feature is experimental, it have some issues. At least >>>>> for me >>>>> this setting is same across workspaces, while it should be >>>>> unique for >>>>> each workspace or even project. >>>>> >>>>> To solve early mentioned issue with project import you need to add next >>>>> config >>>>> in specified lifecycle-mapping-metadata.xml >>>>> >>>>> >>>>> <?xml version="1.0" encoding="UTF-8"?> >>>>> <lifecycleMappingMetadata> >>>>> <pluginExecutions> >>>>> >>>>> <pluginExecution> >>>>> <pluginExecutionFilter> >>>>> <groupId>com.googlecode.fmpp-maven-plugin</groupId> >>>>> <artifactId>fmpp-maven-plugin</artifactId> >>>>> <versionRange>[1.0,)</versionRange> >>>>> <goals> >>>>> <goal>generate</goal> >>>>> </goals> >>>>> </pluginExecutionFilter> >>>>> <action> >>>>> <execute> >>>>> <runOnIncremental>false</runOnIncremental> >>>>> <runOnConfiguration>true</runOnConfiguration> >>>>> </execute> >>>>> </action> >>>>> </pluginExecution> >>>>> >>>>> <pluginExecution> >>>>> <pluginExecutionFilter> >>>>> <groupId>org.codehaus.mojo</groupId> >>>>> <artifactId>javacc-maven-plugin</artifactId> >>>>> <versionRange>[2.4,)</versionRange> >>>>> <goals> >>>>> <goal>javacc</goal> >>>>> </goals> >>>>> </pluginExecutionFilter> >>>>> <action> >>>>> <execute> >>>>> <runOnIncremental>false</runOnIncremental> >>>>> <runOnConfiguration>true</runOnConfiguration> >>>>> </execute> >>>>> </action> >>>>> </pluginExecution> >>>>> >>>>> </pluginExecutions> >>>>> </lifecycleMappingMetadata> >>>>> >>>>> On Sun, Nov 22, 2015 at 9:30 PM, Alexander Reshetov >>>>> <alexander.v.reshe...@gmail.com> wrote: >>>>>> >>>>>> Hello, >>>>>> >>>>>> I tried to import Calcite project into Eclipse and faced some issues. >>>>>> >>>>>> In newly created workspace I select File - Import - Maven - Existing >>>>>> Maven Projects >>>>>> Point "Root Directory" to git cloned dir. Press "Finish". >>>>>> >>>>>> After this steps I got erros: >>>>>> >>>>>> - fmpp-maven-plugin:1.0:generate (1 errors) >>>>>> Description: No marketplace entries found to handle >>>>>> fmpp-maven-plugin:1.0:generate in Eclipse. Please see Help for more >>>>>> information. >>>>>> \- Execution generate-fmpp-sources, in /calcite-core/pom.xml >>>>>> Description: No marketplace entries found to handle Execution >>>>>> generate-fmpp-sources, in /calcite-core/pom.xml in Eclipse. Please >>>>>> see Help for more information. >>>>>> - javacc-maven-plugin:2.4:javacc (2 errors) >>>>>> Description: No marketplace entries found to handle >>>>>> javacc-maven-plugin:2.4:javacc in Eclipse. Please see Help for more >>>>>> information. >>>>>> \- Execution javacc, in /calcite-core/pom.xml >>>>>> Description: No marketplace entries found to handle Execution >>>>>> javacc, in /calcite-core/pom.xml in Eclipse. Please see Help for more >>>>>> information. >>>>>> \- Execution javacc, in /calcite-piglet/pom.xml >>>>>> Description: No marketplace entries found to handle Execution >>>>>> javacc, in /calcite-piglet/pom.xml in Eclipse. Please see Help for >>>>>> more information. >>>>>> >>>>>> After some googling it pointed out that while Eclipse uses incremental >>>>>> compilation, >>>>>> his m2eclipse plugin should have information from maven plugins about >>>>>> lifecycle management. >>>>>> >>>>>> See [1] for more details regarding this behaviour. >>>>>> >>>>>> I also found similar issue (already closed) in Apache Drill. See Jira >>>>>> ticket [2] and pull request >>>>>> for it [3]. >>>>>> >>>>>> I modified pom.xml in calcite-core and calcite-piglet modules, which >>>>>> caused this issue and >>>>>> it was fixed for me. See git diffs [4] and [5]. >>>>>> >>>>>> There is also errors from checkstyle checks, but probably it's just my >>>>>> setup. Didn't investigate yet. >>>>>> >>>>>> [1] - >>>>>> http://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html >>>>>> [2] - https://issues.apache.org/jira/browse/DRILL-445 >>>>>> [3] - >>>>>> >>>>>> https://github.com/apache/drill/commit/1e25c0d287b8ca55d7ae3242b638659c68d115da >>>>>> [4] - http://pastebin.com/VsV4RcG2 >>>>>> [5] - http://pastebin.com/Dhf9VJrS
