Hi Julian, Thanks for the reminder. I just added the comment per your suggestion to the JIRA case.
Regards, Jinfeng On Tue, Dec 1, 2015 at 1:26 PM, Julian Hyde <[email protected]> wrote: > Jinfeng, > > When you check in a fix to master branch and mark a JIRA case fixed, > please add a comment to the case: > > Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/xxxxxxxx. > [ Thanks for the ( patch | PR ), <contributor>! ] > > This is important, because it allows people to easily review the change > after the event. > > Julian > > > Begin forwarded message: > > *From: *asfgit <[email protected]> > *Date: *November 30, 2015 at 3:23:05 PM PST > *To: *apache/calcite <[email protected]> > *Cc: *Julian Hyde <[email protected]> > *Subject: **Re: [calcite] [CALCITE-966] VolcanoPlanner should clear > ruleNames in order to avoid… (#167)* > > Merged #167 <https://github.com/apache/calcite/pull/167>. > > — > Reply to this email directly or view it on GitHub > <https://github.com/apache/calcite/pull/167#event-478350397>. > > >
