Thanks for catching up this one guys... And thanks for taking care of it Julian.
I was convinced I had run the test suite on the right branch... Not the first time it happens, I will try to take more care. -- Jesús On 1/12/16, 9:07 PM, "Jinfeng Ni" <jinfengn...@gmail.com> wrote: >Sorry about the trailing '.' in the commit message. I forgot to remove >the trailing '.' before push the commit. On Drill side, we do not >impose such commit message rule. That makes a bit hard to remember >each time. > >Next time, I'll double check the Calcite rules before commit. > > > >On Tue, Jan 12, 2016 at 10:16 AM, Julian Hyde <jh...@apache.org> wrote: >> Seems to have been introduced by Jesus' >> https://github.com/apache/calcite/commit/9f6f23de06791a3d2de1672b55bfdf7d6396bc78. >> It's not intermittent. But at least it's an improvement! "NOT (x IS >> NOT NULL)" becomes "x IS NULL". I'll amend the commit with a fix. >> >> I'll also remove the '.' on the end of the >> https://github.com/apache/calcite/commit/052c7447f3ba8b3a5fae3ff59ee8e723550a4b1e >> commit message. Because I'm anal. >> >> Expect to see a couple of "forced push" commits to master in the next >> 30 minutes. >> >> Julian >> >> >> On Tue, Jan 12, 2016 at 8:36 AM, Josh Elser <josh.el...@gmail.com> wrote: >>> I just saw the failure too. Was rerunning to make sure it wasn't a flaky >>> test. >>> >>> >>> Jinfeng Ni wrote: >>>> >>>> On commit: >>>> >>>> git log >>>> commit 9f6f23de06791a3d2de1672b55bfdf7d6396bc78 >>>> >>>> Failed tests: >>>> SqlToRelConverterTest.testCorrelationNotExistsAndFilter:1692 plan >>>> expected:<...alFilter(condition=[[NOT(IS NOT NULL($12)])]) >>>> LogicalJoi...> but was:<...alFilter(condition=[[IS NULL($12])]) >>>> LogicalJoi...> >>>> >>>> Tests run: 2687, Failures: 1, Errors: 0, Skipped: 87 >>>> >>>> Anyone saw the same failure? >>>> >>>> Regards, >>>> >>>> Jinfeng >
