I was thinking of testing on the minimum (13.0.1), the default (18.0) and the 
maximum (19.0) and no other versions.

If this needs further discussion let’s continue at 
https://issues.apache.org/jira/browse/CALCITE-1111.

> On Mar 1, 2016, at 2:16 PM, Josh Elser <[email protected]> wrote:
> 
> Julian Hyde wrote:
>> I can see the wisdom of including shaded Jackson and Guava in
>> Avatica's uber jar. But for core Calcite, if as you say, applications
>> can simply override with their own version of various libraries, I
>> would prefer to not shade. I think we should test Calcite on a range
>> of Guava versions (say 11 to 19) and ship by default with a modern one
>> (say 18).
>> 
>> The same goes for Jackson, although I would not be inclined to support
>> old versions for quite so long.
> 
> That's fair. My recommendations were made with the assumption that we 
> wouldn't want to take on that burden in Calcite itself (we know what we test 
> with, we use that, and we insulate users from even knowing that's happening).
> 
> Testing against some ranges of versions would also be acceptable, IMO.

Reply via email to