Jinfeng, In https://issues.apache.org/jira/browse/CALCITE-1150 you added dynamic record types, and the method checkAmbiguousUnresolvedStar is supposed to throw “Column ‘X’ is ambiguous” if more than one field has a dynamic star.
As part of https://issues.apache.org/jira/browse/CALCITE-1208 I am revisiting that code and doing some major refactoring. Did you add any tests where checkAmbiguousUnresolvedStar throws that particular error? I can’t find any; in fact, if I remove all calls to that method, the test suite still passes. Can you suggest some tests for that functionality? I want to make sure I’m not breaking what you did. Julian
