Re: Problem when passing Date parameter in PreparedStatement

[Josh Elser]

Hi Yiming,

Not using the Calendar argument in AvaticaSite#setDate(Date, Calendar) 
looks like a bug (have not looked at the implementation, though). Want 
to file a JIRA issue to investigate this further, please?

If you have the ability to provide a unit test to outline this breakage, 
it would be very helpful. A fix with the test would be the best ;)

- Josh

Yiming Liu wrote:
Hi Calcite devs,

I have problem when passing date parameter in PreparedStatement. Following
is the sample code:

TimeZone tzUtc = TimeZone.getTimeZone("UTC");
Calendar cUtc = Calendar.getInstance(tzUtc);
cUtc.set(2013, 10, 5, 0, 0, 0);
java.sql.Date passSqlDate = new java.sql.Date(cUtc.getTimeInMillis());
statement.setDate(1, passSqlDate, cUtc);

I try to pass Date'2013/11/5' to the database, but from the debug info
I found the

database received '2013/10/4' (GMT -8 Timezone) always. It ignored the
Calendar I passed in.


There are some Calcite code a little strange, I have marked by color:

Why setTimestamp and setTime have effective parameter 'calendar', but
setDate ignore the

parameter. Is that the root cause?

AvaticaSite.java

Line 189-199

   public void setTimestamp(Timestamp x, Calendar calendar) {
     slots[index] = wrap(ColumnMetaData.Rep.JAVA_SQL_TIMESTAMP, x, calendar);
   }

   public void setTime(Time x, Calendar calendar) {
     slots[index] = wrap(ColumnMetaData.Rep.JAVA_SQL_TIME, x, calendar);
   }

   public void setDate(Date x, Calendar cal) {
     slots[index] = wrap(ColumnMetaData.Rep.JAVA_SQL_DATE, x, calendar);
   }