-1 (binding)

Downloaded, checked hashes, LICENSE, NOTICE; built on OS X using JDK 1.8. OK so 
far.

I ran the tests and had one test failure:

Tests run: 267, Failures: 1, Errors: 0, Skipped: 20, Time elapsed: 57.83 sec 
<<< FAILURE! - in org.apache.calcite.test.JdbcTest
testVersion(org.apache.calcite.test.JdbcTest)  Time elapsed: 0.003 sec  <<< 
FAILURE!
java.lang.AssertionError: null
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.apache.calcite.test.JdbcTest.testVersion(JdbcTest.java:1054)

Other problems:
* README says “1.8.0”, should say “1.9.0”
* Ditto howto.md
* In pom.xml, version.minor is 8.

The last of these cause the JDBC driver to return the wrong version, and 
explains the failure of JdbcTest.testVersion, and is a show-stopper.

Julian


> On Sep 16, 2016, at 2:21 PM, Jesus Camachorodriguez <jcama...@apache.org> 
> wrote:
> 
> Hi all,
> 
> I have created a build for Apache Calcite 1.9.0, release candidate 0.
> 
> Thanks to everyone who has contributed to this release.
> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.9.0/site/_docs/history.md
> 
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/calcite/commit/e371a39
> 
> Its hash is e371a3950094cbf3d974b12f7df87dff4caf47a7.
> 
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.9.0-rc0/
> 
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 7f2b61663072de86134ce6fa07ce322a
> src.tar.gz.sha1 0c5fe8f91cc1350142a08673e501e45970162411
> src.zip.md5 b2ab48c904bf2f2df2f3485e72ef6e32
> src.zip.sha1 72af6dfd8f191a3e513f87b7511808744cd4998b
> 
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1023
> 
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jcamacho.asc
> 
> Please vote on releasing this package as Apache Calcite 1.9.0.
> 
> The vote is open for the next 96 hours and passes if a majority of
> at least three +1 PMC votes are cast.
> 
> [ ] +1 Release this package as Apache Calcite 1.9.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
> 
> 
> Here is my vote:
> 
> +1 (binding)
> 
> Jesús
> 
> 
> 

Reply via email to