+1 (non-binding)

Downloaded sources and verified tar.gz and zip, checked hash, ran `mvn
clean install` to both sources with JDK 8, macOS 10.12 and the build passed.

Thanks,
Jungtaek Lim (HeartSaVioR)

2016년 10월 10일 (월) 오전 5:13, Jacques Nadeau <[email protected]>님이 작성:

> Downloaded, reviewed important root files. Built and tested on OSX JDK7
>
> +1 (binding)
>
> Some random notes on DEPENDENCIES... it seems like we have multiple
> different versions of some dependencies in Calcite which is pretty weird...
> We should probably make sure to only source one across the project.
>
>   - Guava: Google Core Libraries for Java (
> http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:15.0
>     License: The Apache Software License, Version 2.0  (
> http://www.apache.org/licenses/LICENSE-2.0.txt)
>   - Guava: Google Core Libraries for Java (
> http://code.google.com/p/guava-libraries/guava)
> com.google.guava:guava:bundle:18.0
>     License: The Apache Software License, Version 2.0  (
> http://www.apache.org/licenses/LICENSE-2.0.txt)
>   - Compress-LZF (http://github.com/ning/compress)
> com.ning:compress-lzf:bundle:1.0.2
>     License: Apache License 2.0  (
> http://www.apache.org/licenses/LICENSE-2.0.html)
>   - Compress-LZF (http://github.com/ning/compress)
> com.ning:compress-lzf:bundle:1.0.3
>     License: Apache License 2.0  (
> http://www.apache.org/licenses/LICENSE-2.0.html)
>   - Netty/All-in-One (http://netty.io/netty-all/)
> io.netty:netty-all:jar:4.0.29.Final
>     License: Apache License, Version 2.0  (
> http://www.apache.org/licenses/LICENSE-2.0)
>   - Netty/Buffer (http://netty.io/netty-buffer/)
> io.netty:netty-buffer:jar:4.0.33.Final
>     License: Apache License, Version 2.0  (
> http://www.apache.org/licenses/LICENSE-2.0)
>
>
> And some other weird things, such as:
>
> - empty (http://nexus.sonatype.org/oss-repository-hosting.html/unused)
> org.spark-project.spark:unused:jar:1.0.0
>
> From: 'Oracle' (http://openjdk.java.net/)
>   - JMH Core (http://openjdk.java.net/projects/code-tools/jmh/jmh-core/)
> org.openjdk.jmh:jmh-core:jar:1.11.2
>     License: GNU General Public License (GPL), version 2, with the
> Classpath exception  (http://openjdk.java.net/legal/gplv2+ce.html)
>
> Note that I believe the above is an optional dependency (which is allowed)
> but our dependency file doesn't clearly state that.
>
>
>
>
>
> On Sun, Oct 9, 2016 at 12:39 AM, Jesus Camacho Rodriguez <
> [email protected]> wrote:
>
> > Julian, you are right that we did obsolete them, but I realized we had
> not
> > updated the instructions to verify a release, thus I left the .md5 and
> > .sha1
> > files so anybody can verify the release by just following the
> instructions.
> > I logged https://issues.apache.org/jira/browse/CALCITE-1421 , so in next
> > release we will be able to obsolete them completely.
> >
> > --
> > Jesús
> >
> >
> >
> > On 10/8/16, 8:53 PM, "Julian Hyde" <[email protected]> wrote:
> >
> > >+1 (binding)
> > >
> > >Downloaded, checked LICENSE, NOTICE, README, release notes, checksums,
> > >maven artifacts. Built using JDK 1.8 on Ubuntu Linux.
> > >
> > >It's curious that the
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.10.0-rc1/
> > >directory contains .md5 and .sha1 files as well as .mds files. I
> > >thought we obsoleted .md5 and .sha1 in favor of .mds last release.
> > >Let's discuss in another thread after the vote closes.
> > >
> > >Julian
> > >
> > >
> > >On Fri, Oct 7, 2016 at 3:42 PM, Jesus Camachorodriguez
> > ><[email protected]> wrote:
> > >> Hi all,
> > >>
> > >> I have created a build for Apache Calcite 1.10.0, release candidate 1.
> > >>
> > >> Thanks to everyone who has contributed to this release.
> > >> You can read the release notes here:
> > >> https://github.com/apache/calcite/blob/calcite-1.10.0/
> > site/_docs/history.md
> > >>
> > >> The commit to be voted upon:
> > >> http://git-wip-us.apache.org/repos/asf/calcite/commit/448dd85
> > >>
> > >> Its hash is 448dd85832819b4d22682ffe7908d8058da7c778.
> > >>
> > >> The artifacts to be voted on are located here:
> > >> https://dist.apache.org/repos/dist/dev/calcite/apache-
> > calcite-1.10.0-rc1/
> > >>
> > >> The hashes of the artifacts are as follows:
> > >> src.tar.gz.md5 de926cf5e44930950ef91e953d640eed
> > >> src.tar.gz.sha1 5edb81494aa7e7c31dd4ee6aefdf549c95027a0a
> > >> src.zip.md5 5e19f9abbd293986d56c0490af241ed6
> > >> src.zip.sha1 1dad2cfa73f459067c23993c3f8ae1b2c45f8b5b
> > >>
> > >> A staged Maven repository is available for review at:
> > >> https://repository.apache.org/content/repositories/
> > orgapachecalcite-1027
> > >>
> > >> Release artifacts are signed with the following key:
> > >> https://people.apache.org/keys/committer/jcamacho.asc
> > >>
> > >> Please vote on releasing this package as Apache Calcite 1.10.0.
> > >>
> > >> The vote is open for the next 96 hours and passes if a majority of
> > >> at least three +1 PMC votes are cast.
> > >>
> > >> [ ] +1 Release this package as Apache Calcite 1.10.0
> > >> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > >> [ ] -1 Do not release this package because...
> > >>
> > >>
> > >> Here is my vote:
> > >>
> > >> +1 (binding)
> > >>
> > >> Jesús
> > >>
> > >>
> > >>
> > >>
> > >
> >
>

Reply via email to