Josh, I like how you’ve enabled GitHub integration for the new calcite-avatica repo. So GitHub review comments now appear in the JIRA case.
But I don’t think the review comments should go to the dev list. They should only go to people following that particular JIRA. I had to moderate this one through, by the way. Julian > On Mar 31, 2017, at 5:15 PM, julianhyde <[email protected]> wrote: > > Github user julianhyde commented on the issue: > > https://github.com/apache/calcite-avatica/pull/1 > > Builds fine. Tests pass. Intellij loads up fine. > > * In pom.xml, change connection and developerConnection to > scm:git:https://git-wip-us.apache.org/repos/asf/calcite.git - otherwise > release build will fail. > > * A few occurrences of "calcite dependencies first" in `pom.xml` files. > > * There's a `.gitignore` under tck that I'm not sure is still required. > > * A few updates needed in `howto.md`, e.g. `git tag -d > apache-calcite-X.Y.Z` (but `dist/dev/calcite` is still fine) > > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > ---
