Sure, thanks, will do On Thu, Jun 29, 2017 at 10:50 PM, Julian Hyde <[email protected]> wrote: > OK, I will review. > > Next time, please put these comments in the JIRA case, not as an email the > dev list. It reduces traffic on the dev list, and it makes the history clear > to whoever is reading the JIRA. Anyone who is interested in that case will > already have subscribed to it as a “watcher”. > >> On Jun 29, 2017, at 10:11 AM, Atri Sharma <[email protected]> wrote: >> >> Hi Julian, >> >> I have fixed your comments and updated. Please take a look and let me know. >> >> Regards, >> >> Atri >> >> On Wed, Jun 28, 2017 at 1:29 AM, Julian Hyde <[email protected]> wrote: >>> Thanks for the PR! See my review comments in >>> https://issues.apache.org/jira/browse/CALCITE-873. >>> >>> On Tue, Jun 27, 2017 at 11:18 AM, Atri Sharma <[email protected]> wrote: >>>> Just noticed that my editor decided to fold the imports automatically. Will >>>> fix that tomorrow >>>> >>>> On Jun 27, 2017 11:33 PM, "Atri Sharma" <[email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Please find PR for Calcite 873 at: >>>>> >>>>> https://github.com/apache/calcite/pull/485 >>>>> >>>>> Please let me know if there are any comments or feedback. >>>>> >>>>> Regards, >>>>> >>>>> Atri >>>>> >>>>> -- >>>>> Regards, >>>>> >>>>> Atri >>>>> l'apprenant >>>>> >> >> >> >> -- >> Regards, >> >> Atri >> l'apprenant >
-- Regards, Atri l'apprenant
