Makes sense. It's already there in the SqlDialect.create method, it
just doesn't become a field in the SqlDialect object.

By the way, DatabaseProduct is intentionally coarser than SqlDialect;
as an enum, it can't be extended easily, but it can be used in switch
statements. So, several dialect objects might share the same
DatabaseProduct. E.g. MySQL 5.5 and MySQL 6 and MariaDB would all
share the DatabaseProduct.MYSQL.

On Sat, Jul 1, 2017 at 10:43 AM, Jess Balint <[email protected]> wrote:
> Anybody considered putting the database version #'s in SqlDialect? There
> are many things that can't be decided on product alone, e.g. OFFSET/FETCH
> available only since MSSQL 2012 and Oracle 12.
>
> Jess

Reply via email to