Ah, I see. So maybe we just need to remove the square brackets on PR
titles. I'll try that next time I have code for review (or if someone else
gets a chance) and we'll see what happens. Thanks Josh!

--
Michael Mior
[email protected]

2017-12-11 17:22 GMT-05:00 Josh Elser <[email protected]>:

> I'm confused, we definitely have GH+JIRA integration enabled (at least, in
> part) already. See https://issues.apache.org/jira/browse/CALCITE-1922 for
> an example.
>
> Our commit message "structure" is at odds with the integration, though
> ([CALCITE-1234] would not link them, you have to change the PR title to
> just be CALCITE-1234). But, maybe it's just not set up for the
> github.com/apache/calcite repository, just the calcite-avatica repo. I
> don't recall how the configuration works on the ASF infra side.
>
>
> On 12/10/17 7:49 PM, Michael Mior wrote:
>
>> Was just reminded of this after creating a PR for the calcite-avatica repo
>> and seeing this in action. Since there are no objections, seems like it
>> would be good to get this set up.
>>
>> @Julian Unfortunately I'm currently ignorant as to how to request this
>> from
>> infra. Is it just a matter of creating an issue on the INFRA JIRA?
>>
>> --
>> Michael Mior
>> [email protected]
>>
>> 2017-11-27 16:21 GMT-05:00 Julian Hyde <[email protected]>:
>>
>> No objections from me, as long as it doesn’t cause excessive posts to the
>>> dev list.
>>>
>>> As a small project this is an area we have under-invested. Larger
>>> projects
>>> such as Spark seem to have very nice integration between GitHub, JIRA and
>>> various CIs.
>>>
>>> Julian
>>>
>>>
>>> On Nov 27, 2017, at 1:15 PM, Michael Mior <[email protected]> wrote:
>>>>
>>>> Sounds fine to me personally although perhaps others have some
>>>> objections
>>>> I'm not aware of.
>>>>
>>>> --
>>>> Michael Mior
>>>> [email protected]
>>>>
>>>> 2017-11-27 15:44 GMT-05:00 Enrico Olivelli <[email protected]>:
>>>>
>>>> Hi,
>>>>> I see that there is no automatic link between PRs and JIRA.
>>>>> In Apache BookKeeper (I am committer there) we have such link: if you
>>>>>
>>>> name
>>>
>>>> a PR with for instance CALCITE-Xxx and you cite the issue id in commit
>>>>> messages Apache Github bot is able to copy every comment to JIRA
>>>>> automatically.
>>>>> I think this we be very useful.
>>>>> I think that just an infra ticket can enable it.
>>>>>
>>>>> Cheers
>>>>> Enrico
>>>>> --
>>>>>
>>>>>
>>>>> -- Enrico Olivelli
>>>>>
>>>>>
>>>
>>>
>>

Reply via email to