Sure, will do. Also, any reason not to update source/target versions for maven-compiler-plugin and reconfigure Travis for JDK 8?
-- Michael Mior [email protected] 2018-01-16 16:08 GMT-05:00 Julian Hyde <[email protected]>: > Michael, > > You mentioned the PR to add Geode support, https://github.com/apache/ > calcite/pull/571 <https://github.com/apache/calcite/pull/571>, > CALCITE-2059. We’ve been neglecting it. Do you have the time to review & > commit it? > > Julian > > > > On Jan 10, 2018, at 11:40 AM, Michael Mior <[email protected]> wrote: > > > > Also, I forgot to add that I would also update the source and target > > versions for maven-compiler-plugin to 1.8. I think that this would allow > us > > to close CALCITE-2027. (Although if Julian wants to leave it open to > track > > things we can now do with 1.8 that makes sense to me as well.) > > > > -- > > Michael Mior > > [email protected] > > > > 2018-01-10 14:34 GMT-05:00 Michael Mior <[email protected]>: > > > >> Ah, I see. I did have a Jenkins account but I needed to add myself to > the > >> hudson-jobadmin group via Whimsy. Thanks Josh! > >> > >> I've gone ahead and removed JDK 1.7 on Jenkins. If there are no > >> objections, I'll also remove openjdk7 from the Travis config and add > >> oraclejdk9 instead. > >> > >> -- > >> Michael Mior > >> [email protected] > >> > >> 2018-01-10 14:24 GMT-05:00 Josh Elser <[email protected]>: > >> > >>> Nope. As long as you have a Jenkins account, you should be able to edit > >>> the job. It's the wild-west (so don't go changing other folks' jobs > :P). > >>> > >>> If you need a Jenkins account, that would be a request to INFRA in some > >>> form or another. > >>> > >>> > >>> On 1/10/18 1:54 PM, Michael Mior wrote: > >>> > >>>> How do we go about removing JDK 7 tests on Jenkins? Does this require > an > >>>> INFRA ticket? > >>>> > >>>> -- > >>>> Michael Mior > >>>> [email protected] > >>>> > >>>> 2018-01-10 13:32 GMT-05:00 Julian Hyde <[email protected]>: > >>>> > >>>> Yes. > >>>>> > >>>>> JDK 8 is an exciting opportunity to modernize the code; we can make > it > >>>>> less verbose by converting anonymous inner classes to lambdas, and by > >>>>> using > >>>>> “default” functions in interfaces. For new features that help > >>>>> significantly > >>>>> with code style, I’d like someone to take a pass over the code to use > >>>>> those > >>>>> features wherever applicable. I think that would be better than using > >>>>> the > >>>>> JDK 8 only for new code. > >>>>> > >>>>> I’ve listed some of the features in https://issues.apache.org/ > >>>>> jira/browse/CALCITE-2027 <https://issues.apache.org/ > >>>>> jira/browse/CALCITE-2027>. > >>>>> > >>>>> Julian > >>>>> > >>>>> > >>>>> On Jan 10, 2018, at 10:05 AM, Michael Mior <[email protected]> > wrote: > >>>>>> > >>>>>> Now that 1.15.0 has been released, can we update CI to remove > testing > >>>>>> for > >>>>>> JDK 7? It would be nice to be able to start using JDK 8 features. > Also, > >>>>>> > >>>>> the > >>>>> > >>>>>> following PR for Apache Geode support doesn't support JDK 7 (because > >>>>>> > >>>>> Geode > >>>>> > >>>>>> doesn't): https://github.com/apache/calcite/pull/571 > >>>>>> > >>>>>> -- > >>>>>> Michael Mior > >>>>>> [email protected] > >>>>>> > >>>>> > >>>>> > >>>>> > >>>> > >> > >
