Thanks. Will do that. I have CALCITE-2172 <https://issues.apache.org/jira/browse/CALCITE-2172> created for this.
Btw -- would it be appropriate to add Gian's style file to Calcite somewhere (and where would that be), or should I just reference it? I personally like the idea of having all we need under the project repository, but IDE setup might be little bit too tangential to a code base. On Wed, Feb 7, 2018 at 8:47 PM, Julian Hyde <[email protected]> wrote: > The problem with ExtensionSqlParserImpl might be a bug with how > Intellij handles generated .java files under "test", and maybe there's > a workaround or fix. Compared to what I've seen in other projects it's > pretty smooth. (In the past you'd have to maintain an IDE config, > whereas now the IDE configures its project from solely from the pom. > This a big improvement over that.) > > I recommend that you add a section (question) to > https://calcite.apache.org/docs/howto.html and reference it from > https://calcite.apache.org/develop/#getting-started. > > On Wed, Feb 7, 2018 at 5:39 PM, Edmon Begoli <[email protected]> wrote: > > That worked but ... > > > > Is there something we can do to make this process more consistent, or is > > this just how it is going to be, and make a note of it? > > > > I am trying to collect your instructions, and turn them into a project > > documentation for the web site, so we can have a section with something > > like "setting up your IDE" for IDEA, eclipse, .... > > > > > > On Wed, Feb 7, 2018 at 8:27 PM, Julian Hyde <[email protected]> wrote: > > > >> Ah yes. You need to build ExtensionSqlParserImpl first using maven. > >> From the command line: > >> > >> $ mvn -DskipTests clean install > >> > >> I periodically get that error (e.g. after a "git pull") and repeat > >> that command. Most of the time Intellij is able to build > >> incrementally. > >> > >> On Wed, Feb 7, 2018 at 4:14 PM, Edmon Begoli <[email protected]> wrote: > >> > I followed all the steps, and everything was good, but upon running > >> > testWinAgg I got: > >> > > >> > Information:java: Errors occurred while compiling module > 'calcite-core' > >> > Information:javac 1.8.0_161 was used to compile java sources > >> > Information:2/7/18, 7:14 PM - Compilation completed with 1 error and 0 > >> > warnings in 15s 794ms > >> > > >> > <my > >> > path>/src/calcite/core/src/test/java/org/apache/calcite/sql/parser/ > >> parserextensiontesting/ExtensionSqlParserTest.java > >> > > >> > Error:(36, 12) java: cannot find symbol > >> > symbol: variable ExtensionSqlParserImpl > >> > location: class > >> > org.apache.calcite.sql.parser.parserextensiontesting. > >> ExtensionSqlParserTest > >> > > >> > > >> > > >> > On Wed, Feb 7, 2018 at 12:52 AM, Julian Hyde <[email protected]> > wrote: > >> > > >> >> Then navigate to the method JdbcTest.testWinAgg by typing > >> >> control-alt-shift-n (Navigate > Symbol) followed by testWinAgg. And > >> >> run it in the debugger by typing control-shift-f10 (right-click Run). > >> >> > >> >> You can run any test method or class in Calcite this way. > >> >> > >> >> Navigate to CalciteSuite to run every test in core. > >> >> > >> >> > >> >> On Tue, Feb 6, 2018 at 7:36 PM, Gian Merlino <[email protected]> wrote: > >> >> > Welcome to Calcite!! > >> >> > > >> >> > To start go to File > Open... and open up Calcite's "pom.xml" file. > >> When > >> >> > IntelliJ asks if you want to open it as a project or a file, say > you > >> >> want a > >> >> > project. Also say yes when it asks if you want a new window. Then, > >> >> > IntelliJ's Maven project importer should handle the rest. > >> >> > > >> >> > I also made this (partially complete) IntelliJ code style config > that > >> you > >> >> > can import: https://gist.github.com/gianm/ > >> 27a4e3cad99d7b9b6513b6885d3cfc > >> >> c9. > >> >> > It doesn't do everything needed to make Calcite's style checker > happy, > >> >> but > >> >> > it does a decent amount of it. To import, go to Preferences > > Editor > > >> >> Code > >> >> > Style, click the gear next to "scheme", then Import Scheme > > IntelliJ > >> >> IDEA > >> >> > Code Style XML. > >> >> > > >> >> > Gian > >> >> > > >> >> > On Tue, Feb 6, 2018 at 6:08 PM, Edmon Begoli <[email protected]> > >> wrote: > >> >> > > >> >> >> What is your exact setup workflow with IDEA to get development up > and > >> >> >> running? > >> >> >> > >> >> >> So far, I used command line and Sublime Text. > >> >> >> > >> >> >> Would like to try IDEA for Calcite development. > >> >> >> > >> >> >> Checked out calcite to my src directory. > >> >> >> > >> >> >> Now I am in IDEA. > >> >> >> > >> >> >> What next? > >> >> >> > >> >> > >> >
