Il lun 9 apr 2018, 22:20 Cade Markegard <cademarkeg...@gmail.com> ha scritto:
> Not sure if this is related, but it seems like Janino doesn't support Java8 > lambdas under "Limitations" in http://janino-compiler.github.io/janino/ This should not be a problem, we are not generating java sources with lambdas (maybe in future?). I will be happy to do some trials with new Janino, but I guess that would be the only way (or to drop Janino, but I think it will be harder). I have not much time these days. Anyhow I am testing my apps on jdk10 and Calcite is working like a charm ! Enrico > > > On Mon, Apr 9, 2018 at 12:54 PM Julian Hyde <jh...@apache.org> wrote: > > > I didn’t try. We’re on janino 2.7.6. The 2.x line only goes up to 2.7.8. > > I’m not eager to try upgrading to 3.x (latest release is 3.0.8) > especially > > as they don’t explicitly mention fixing a JDK 8 issue. > > > > http://janino-compiler.github.io/janino/changelog.html < > > http://janino-compiler.github.io/janino/changelog.html> > > > > > > > On Apr 9, 2018, at 12:42 PM, Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > > Il lun 9 apr 2018, 21:37 Julian Hyde <jh...@apache.org <mailto: > > jh...@apache.org>> ha scritto: > > > > > >> Don’t have the error stack, but janino could not compile generated > code > > >> because it said an “unwrap” method did not exist. > > >> > > >> There were no lambdas. I think perhaps that version of janino could > not > > >> fully understand the Calcite class files. > > >> > > >> To reproduce, change 2 lines in core/pom.xml and run “mvn test”. > > >> > > > > > > Did you try to update to latest Janino? > > > It seems to that we have an old version (2.7.6) > > > > > > Enrico > > > > > >> > > >> Julian > > >> > > >> > > >>> On Apr 9, 2018, at 12:15 PM, Enrico Olivelli <eolive...@gmail.com> > > >> wrote: > > >>> > > >>> Il lun 9 apr 2018, 19:05 Julian Hyde <jh...@apache.org> ha scritto: > > >>> > > >>>> Has anyone had any luck using JDK 8 syntax (e.g. “->” for lambdas) > in > > >>>> Calcite? > > >>>> > > >>>> In core/pom.xml I changed source=1.7 target=1.7 to source=8 target=8 > > and > > >>>> it allowed the syntax but it seemed to break any tests that relied > on > > >>>> janino. > > >>>> > > >>> > > >>> Julian, > > >>> Could you please share a stacktrace of your error? > > >>> As far as I know using lambdas is not only a matter of syntactic > sugar > > >> but > > >>> they are more efficient than simple anonymous classes. > > >>> > > >>> Cheers > > >>> Enrico > > >>> > > >>> > > >>>> Related: https://issues.apache.org/jira/browse/CALCITE-2027 < > > >>>> https://issues.apache.org/jira/browse/CALCITE-2027> > > >>>> > > >>>> Julian > > >>>> > > >>>> -- > > >>> > > >>> > > >>> -- Enrico Olivelli > > >> > > >> -- > > > > > > > > > -- Enrico Olivelli > > > > > -- -- Enrico Olivelli
