I'd definitely be open to this if we can get something stable working. Anything which gets better regular test coverage for the adapters is great in my books.
-- Michael Mior [email protected] Le lun. 28 mai 2018 à 23:47, Andrei Sereda <[email protected]> a écrit : > Hello, > > Current IT tests require manual startup and seeding of data-sources (Mongo, > ES, Geode etc.) from separate git project (see calcite-test-dataset > <https://github.com/vlsi/calcite-test-dataset> ). While useful they force > developer to bootstrap additional environment on his own and don't work by > default (unless properly initialized). > > Would you consider using "fake" (in memory) data-sources for unit tests > like: > - Fongo <https://github.com/fakemongo/fongo> for Mongo > - TestNode > < > https://github.com/dremio/dremio-oss/blob/master/plugins/elasticsearch/src/test/java/org/elasticsearch/node/ElasticTestNode.java > > > for ElasticSearch > > I'm not proposing to stop using IT but rather having a better coverage for > unit tests (with fakes) > > Interesting to hear your opinion. > > Regards, > Andrei. >
