Why add a suppression? Was it not possible to fix the problem?
On Sat, Jun 9, 2018 at 11:41 AM, <[email protected]> wrote: > Repository: calcite-avatica > Updated Branches: > refs/heads/master acb675de9 -> 4c6b55e08 > > > [CALCITE-2352] Fix missing suppressions.xml change > > Add change to suppressions.xml for generated FilteredConstants > file, after updating to checkstyle 6.18 > > > Project: http://git-wip-us.apache.org/repos/asf/calcite-avatica/repo > Commit: http://git-wip-us.apache.org/repos/asf/calcite-avatica/commit/4c6b55e0 > Tree: http://git-wip-us.apache.org/repos/asf/calcite-avatica/tree/4c6b55e0 > Diff: http://git-wip-us.apache.org/repos/asf/calcite-avatica/diff/4c6b55e0 > > Branch: refs/heads/master > Commit: 4c6b55e08f124ab1826820ff975687563c1790e6 > Parents: acb675d > Author: Laurent Goujon <[email protected]> > Authored: Sat Jun 9 11:32:59 2018 -0700 > Committer: Laurent Goujon <[email protected]> > Committed: Sat Jun 9 11:32:59 2018 -0700 > > ---------------------------------------------------------------------- > src/main/config/checkstyle/suppressions.xml | 1 + > 1 file changed, 1 insertion(+) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/calcite-avatica/blob/4c6b55e0/src/main/config/checkstyle/suppressions.xml > ---------------------------------------------------------------------- > diff --git a/src/main/config/checkstyle/suppressions.xml > b/src/main/config/checkstyle/suppressions.xml > index 9c31837..1f54d7b 100644 > --- a/src/main/config/checkstyle/suppressions.xml > +++ b/src/main/config/checkstyle/suppressions.xml > @@ -30,6 +30,7 @@ limitations under the License. > <suppress checks=".*" > files="core[/\\]src[/\\]main[/\\]java[/\\]org[/\\]apache[/\\]calcite[/\\]avatica[/\\]proto"/> > <suppress checks=".*" files="log4j.properties"/> > <suppress checks=".*" files="auth-users.properties"/> > + <suppress checks=".*" files="FilteredConstants.java"/> > > <!-- This file triggers https://github.com/checkstyle/checkstyle/issues/92, > through no fault of its own. --> >
