Good point. Since ES is written in Java and we're running the same code testing on a local node, it's probably not necessary to test against a separate ES cluster. -- Michael Mior mm...@apache.org
Le lun. 11 juin 2018 à 01:44, Christian Beikov <christian.bei...@gmail.com> a écrit : > I don't see a reason for running ES tests again on a "real" ES instance. > What does that even mean? > > With a local node, we would be testing functionality against almost the > real thing. The only difference is that a real setup has a cluster, but > that doesn't change the functionality. So I'm all in on using just a > local node which is also something I wanted to do for a long time, but > you got to it before I did. > > Do the tests succeed with the local node? > > > Mit freundlichen Grüßen, > ------------------------------------------------------------------------ > *Christian Beikov* > Am 07.06.2018 um 20:47 schrieb Andrei Sereda: > > Hi Volodymyr, > > > > We're trying to bridge the gap between unit and integration tests (which > > are run infrequently) using fakes > > <https://martinfowler.com/bliki/InMemoryTestDatabase.html> in Calcite. > > > > Currently the plan is to use fongo (see CALCITE-2345 for mongo adapter) > and > > local elastic node (see CALCITE-2347 for elastic). > > > > During unit tests code will run against fake instances. For IT profile > they > > will run against real instances (as before). > > > > Regards, > > Andrei. > > > > > > On Thu, Jun 7, 2018 at 2:32 PM, Julian Hyde <jh...@apache.org> wrote: > > > >> Unfortunately, I don’t know. We don’t run the integration tests as often > >> as we should. > >> > >>> On Jun 7, 2018, at 10:20 AM, Vova Vysotskyi <vvo...@gmail.com> wrote: > >>> > >>> Hi all, > >>> > >>> I tried to run Elasticsearch integration tests for the current master, > >> and > >>> many tests failed. > >>> > >>> Is it a known problem, or just an issue of my env? > >>> > >>> I noticed that one failure appears after the change made in > CALCITE-2316. > >>> Most of the other failures are observed for 1.16 version also. > >>> > >>> Kind regards, > >>> Volodymyr Vysotskyi > >> > >
