One thing that jumped out to me was the use of an explicit type when calling the ArrayList constructor in the parser. I initially thought this was something that Julian had gotten rid of in his big update to support Java 8 syntax. However, I see this still persists in Parser.jj . Is this intentional? -- Michael Mior mm...@apache.org
Le mer. 29 août 2018 à 16:11, Julian Hyde <jh...@apache.org> a écrit : > Somehow I missed this… we have a pull request for JSON support. It’s a big > change (both in terms of importance and the amount of effort). > > https://github.com/apache/calcite/pull/785 < > https://github.com/apache/calcite/pull/785> > > https://issues.apache.org/jira/browse/CALCITE-2266 < > https://issues.apache.org/jira/browse/CALCITE-2266> > > I made a quick review, and it looks good. I see Vladimir has reviewed. Can > someone else (not necessarily a committer) take a look? > > Julian > > >