The .tar.gz contains a .idea directory that is not in source-control:

.idea/
.idea/go.imports.xml
.idea/inspectionProfiles
.idea/workspace.xml
.idea/vcs.xml
.idea/dataSources
.idea/dataSources/8818a189-beb8-4519-a1af-aec6a92afd20.xml
.idea/dataSources/ed276130-2ebd-463d-b1a0-78e39ca4d29f.xml
.idea/calcite-avatica-go.iml
.idea/watcherTasks.xml
.idea/dataSources.local.xml
.idea/usage.statistics.xml
.idea/misc.xml
.idea/dataSources.xml
.idea/modules.xml

In NOTICE, copyright should be 2012-2018 not 2012-2017.

Due to these issues, my vote is -1.

Checked LICENSE, README.md, checksums/signatures, file headers.

I did not build or run tests, or check that dependencies have suitable
licenses. I don't know enough about Go. Can someone else please do
that.

Julian

On Tue, Sep 4, 2018 at 3:38 PM Francis Chuang <[email protected]> wrote:
>
> Hi All,
>
> Just a reminder that Apache Calcite Avatica Go 3.1.0-rc1 is available
> for voting. If you have a chance, please try to run the tests, verify
> the signature and vote. Your vote will be extremely useful to determine
> if this release candidate is suitable to release.
>
> Francis
>
> On 31/08/2018 10:35 AM, Francis Chuang wrote:
> > Hi all,
> >
> > I have created a release for Apache Calcite Avatica Go 3.1.0, release
> > candidate 1.
> >
> > The release notes are available here:
> > https://github.com/apache/calcite-avatica-go/blob/master/site/_docs/go_history.md
> >
> > The commit to be voted on:
> > http://git-wip-us.apache.org/repos/asf/calcite-avatica-go/commit/f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
> >
> > The hash is f564cfa42948b9a5c4c7f98f3e43ab5971bcaeda
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-go-3.1.0-rc1/
> >
> > The hashes of the artifacts are as follows:
> >
> > src.tar.gz.sha256 64BC4D9D 197457DC B0573F12 4A75A298 CB5207D6 FDC14DCB 
> > 675FF731 0555F5A3
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/francischuang.asc
> >
> > Instructions for running the test suite is located here:
> > https://github.com/apache/calcite-avatica-go/blob/master/site/develop/avatica-go.md#testing
> >
> > Please vote on releasing this package as Apache Calcite Avatica Go 3.1.0.
> >
> > To run the tests without a Go environment, install docker and 
> > docker-compose. Then, in the root of the release's directory, run:
> > docker-compose up --build
> >
> > The vote is open for the next 72 hours and passes if a majority of
> > at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite Avatica Go 3.0.0
> > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Francis
> >
>

Reply via email to