You are incorrectly assuming that the sole purpose of that test is to test that particular fix. Yes, it was introduced in that change. But it tests a whole lot else, including things that are currently working but may stop working in future. Or things that work with reasonable performance now and may get slower in future.
Complex tests are hard to find, and I was delighted when someone gave us that huge query. (Have you seen real-world SQL queries? Some are many thousands of lines long. But people rarely contribute them because they depend on proprietary models or data.) CPU time is cheap. Developer time is expensive. Julian > On Sep 6, 2018, at 10:12 AM, Vladimir Sitnikov <[email protected]> > wrote: > > Julian>Dammit, Vladimir. Stop removing tests!! > > The test is there, and it still verifies that DEPTH_FIRST approach is > better. I did not remove the test. > > Julian>You seem to have a personal agenda to make the test suite run in > under a minute > > The agenda is to reduce test suite execution while still keeping test > quality. > > Vladimir
