>I don’t think it’s possible to automate. Well, a rule of "first line should be separated by a blank line" seems to be automatable. The rule of "CALCITE-XXX should be in [...]" seems to be automatable. And so on.
>I was a bit surprised that you, as a committer, had not already committed it setDynamicParam did not look good enough to me https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=blobdiff;f=core/src/main/java/org/apache/calcite/runtime/ResultSetEnumerable.java;h=52c11f9aaf752cea367ae921c04a20e5e6da5488;hp=771772f1ea39d74eee6e9f889ae8d6500f129c7f;hb=53e15af6c5e8e782b2edcd7f5bf4f5f32225d110;hpb=02ca9bc995cac5b4b97855a4d06df46e632d7c22 I'm inclined to incline Avatica to expose TypedValue.setToPreparedStatement(PreparedStatement ps, int index) kind of API, so ResultSetEnumerable.setDynamicParam could be removed altogether. PS. It looks like I've posted the above message twice, sorry for double-posintg. Vladimir
